Closed Bug 1918098 Opened 9 months ago Closed 7 months ago

Upgrade to ruff 0.6.4

Categories

(Developer Infrastructure :: Lint and Formatting, task)

Product:
Developer Infrastructure
Component:
Lint and Formatting
Type:
task

Tracking

(firefox134 fixed)

Status:
RESOLVED FIXED
Milestone:
134 Branch
Tracking Flags:
Tracking Status
firefox134 --- fixed

People

(Reporter: Sylvestre, Assigned: Sylvestre)

References

Details

Attachments

(5 files)

Bug 1918098 - ruff: fix the errors identified by 0.6.4 r?#linter-reviewers
48 bytes, text/x-phabricator-request
Details | Review
Bug 1918098 - ruff: upgrade ruff to v0.6.4 r?#linter-reviewers
48 bytes, text/x-phabricator-request
Details | Review
Bug 1918098 - ruff: --fix some python warning r?#linter-reviewers
48 bytes, text/x-phabricator-request
Details | Review
Bug 1918098 - ruff: --verbose --fix should show the fix command too r?#linter-reviewers
48 bytes, text/x-phabricator-request
Details | Review
Bug 1918098 - ruff: also run --fix for warnings r?#linter-reviewers
48 bytes, text/x-phabricator-request
Details | Review

Our version (0.0.254) is from March 2023

Assignee: nobody → sledru
Status: NEW → ASSIGNED
  • Rename --format to the new option + include it in the verbose command
Attachment #9424268 - Attachment description: Bug 1918098 - Run ruff 0.6.4 on our codebase r?#linter-reviewers → Bug 1918098 - ruff: fix the errors identified by 0.6.4 r?#linter-reviewers

Done with with
$ ./mach lint -l ruff --verbose . --fix --warnings
with this line commented:
https://searchfox.org/mozilla-central/source/tools/lint/python/ruff.py#140

And reformat with
$ ./mach lint -l black --verbose . --fix --warnings

Attachment #9424269 - Attachment description: Bug 1918098 - mozlint/ruff: upgrade ruff to v0.6.4 r?#linter-reviewers → Bug 1918098 - ruff: upgrade ruff to v0.6.4 r?#linter-reviewers
Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/89f52bcdc0be ruff: --verbose --fix should show the fix command too r=linter-reviewers,ahal DONTBUILD

https://hg.mozilla.org/mozilla-central/rev/89f52bcdc0be

Status: ASSIGNED → RESOLVED
Closed: 7 months ago
status-firefox134: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 134 Branch

Reopened for unpublished changesets.

Status: RESOLVED → REOPENED
Keywords: leave-open
Resolution: FIXED → ---
Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/a6c6f0ed3315 ruff: fix the errors identified by 0.6.4 r=linter-reviewers,taskgraph-reviewers,releng-reviewers,webdriver-reviewers,perftest-reviewers,migration-reviewers,jmaher,whimboo,sparky,xpcom-reviewers,beth,ahal,mconley https://hg.mozilla.org/integration/autoland/rev/9e2ed7d78b95 ruff: upgrade ruff to v0.6.4 r=linter-reviewers,ahal
See Also: → 1929876
See Also: → 1929869
See Also: 1929876 →
Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/0181cee9f5da ruff: also run --fix for warnings r=linter-reviewers,ahal DONTBUILD
Keywords: leave-open

https://hg.mozilla.org/mozilla-central/rev/0181cee9f5da

Status: REOPENED → RESOLVED
Closed: 7 months ago → 7 months ago
status-firefox134: affected → fixed
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: